Discussion:
[PATCH] usb: serial: Fix indentation style issue
(too old to reply)
Philip Munksgaard
2014-10-11 13:49:43 UTC
Permalink
Raw Message
Fix a style issue

Signed-off-by: Philip Munksgaard <***@gmail.com>
---
drivers/usb/serial/option.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index d1a3f60..d88998d 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -1616,7 +1616,7 @@ static const struct usb_device_id option_ids[] = {
{ USB_DEVICE(TLAYTECH_VENDOR_ID, TLAYTECH_PRODUCT_TEU800) },
{ USB_DEVICE(LONGCHEER_VENDOR_ID, FOUR_G_SYSTEMS_PRODUCT_W14),
.driver_info = (kernel_ulong_t)&four_g_w14_blacklist
- },
+ },
{ USB_DEVICE_INTERFACE_CLASS(LONGCHEER_VENDOR_ID, SPEEDUP_PRODUCT_SU9800, 0xff) },
{ USB_DEVICE(LONGCHEER_VENDOR_ID, ZOOM_PRODUCT_4597) },
{ USB_DEVICE(LONGCHEER_VENDOR_ID, IBALL_3_5G_CONNECT) },
--
2.1.2
Greg KH
2014-10-11 14:20:49 UTC
Permalink
Raw Message
Post by Philip Munksgaard
Fix a style issue
---
drivers/usb/serial/option.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index d1a3f60..d88998d 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -1616,7 +1616,7 @@ static const struct usb_device_id option_ids[] = {
{ USB_DEVICE(TLAYTECH_VENDOR_ID, TLAYTECH_PRODUCT_TEU800) },
{ USB_DEVICE(LONGCHEER_VENDOR_ID, FOUR_G_SYSTEMS_PRODUCT_W14),
.driver_info = (kernel_ulong_t)&four_g_w14_blacklist
- },
+ },
Why not fix the same 'space' issue on the line before this at the same
time?
Lars Melin
2014-10-11 14:51:04 UTC
Permalink
Raw Message
Post by Greg KH
Post by Philip Munksgaard
Fix a style issue
---
drivers/usb/serial/option.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index d1a3f60..d88998d 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -1616,7 +1616,7 @@ static const struct usb_device_id option_ids[] = {
{ USB_DEVICE(TLAYTECH_VENDOR_ID, TLAYTECH_PRODUCT_TEU800) },
{ USB_DEVICE(LONGCHEER_VENDOR_ID, FOUR_G_SYSTEMS_PRODUCT_W14),
.driver_info = (kernel_ulong_t)&four_g_w14_blacklist
- },
+ },
Why not fix the same 'space' issue on the line before this at the same
time?
Why put the closing brace on a new line?
Joe Perches
2014-10-11 15:36:33 UTC
Permalink
Raw Message
Post by Greg KH
Post by Philip Munksgaard
Fix a style issue
[]
Post by Greg KH
Post by Philip Munksgaard
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
[]
Post by Greg KH
Post by Philip Munksgaard
@@ -1616,7 +1616,7 @@ static const struct usb_device_id option_ids[] = {
{ USB_DEVICE(TLAYTECH_VENDOR_ID, TLAYTECH_PRODUCT_TEU800) },
{ USB_DEVICE(LONGCHEER_VENDOR_ID, FOUR_G_SYSTEMS_PRODUCT_W14),
.driver_info = (kernel_ulong_t)&four_g_w14_blacklist
- },
+ },
Why not fix the same 'space' issue on the line before this at the same
time?
I think there is no space issue on the previous line.
What do you see Greg?
Greg KH
2014-10-11 20:19:01 UTC
Permalink
Raw Message
Post by Joe Perches
Post by Greg KH
Post by Philip Munksgaard
Fix a style issue
[]
Post by Greg KH
Post by Philip Munksgaard
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
[]
Post by Greg KH
Post by Philip Munksgaard
@@ -1616,7 +1616,7 @@ static const struct usb_device_id option_ids[] = {
{ USB_DEVICE(TLAYTECH_VENDOR_ID, TLAYTECH_PRODUCT_TEU800) },
{ USB_DEVICE(LONGCHEER_VENDOR_ID, FOUR_G_SYSTEMS_PRODUCT_W14),
.driver_info = (kernel_ulong_t)&four_g_w14_blacklist
- },
+ },
Why not fix the same 'space' issue on the line before this at the same
time?
I think there is no space issue on the previous line.
What do you see Greg?
I see 'space space tab', just like this line that is being changed.

/me hands Joe a real editor.
Joe Perches
2014-10-12 01:02:11 UTC
Permalink
Raw Message
Post by Greg KH
Post by Joe Perches
Post by Greg KH
Post by Philip Munksgaard
Fix a style issue
[]
Post by Greg KH
Post by Philip Munksgaard
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
[]
Post by Greg KH
Post by Philip Munksgaard
@@ -1616,7 +1616,7 @@ static const struct usb_device_id option_ids[] = {
{ USB_DEVICE(TLAYTECH_VENDOR_ID, TLAYTECH_PRODUCT_TEU800) },
{ USB_DEVICE(LONGCHEER_VENDOR_ID, FOUR_G_SYSTEMS_PRODUCT_W14),
.driver_info = (kernel_ulong_t)&four_g_w14_blacklist
- },
+ },
Why not fix the same 'space' issue on the line before this at the same
time?
I think there is no space issue on the previous line.
What do you see Greg?
I see 'space space tab', just like this line that is being changed.
Right, silly evolution previewer can't differentiate space/tab
Post by Greg KH
/me hands Joe a real editor.
Well, where is it? ;)
Johan Hovold
2014-10-22 09:51:12 UTC
Permalink
Raw Message
Post by Greg KH
Post by Philip Munksgaard
Fix a style issue
---
drivers/usb/serial/option.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index d1a3f60..d88998d 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -1616,7 +1616,7 @@ static const struct usb_device_id option_ids[] = {
{ USB_DEVICE(TLAYTECH_VENDOR_ID, TLAYTECH_PRODUCT_TEU800) },
{ USB_DEVICE(LONGCHEER_VENDOR_ID, FOUR_G_SYSTEMS_PRODUCT_W14),
.driver_info = (kernel_ulong_t)&four_g_w14_blacklist
- },
+ },
Why not fix the same 'space' issue on the line before this at the same
time?
And what about the remaining white-space issues in this file? Do we
really want to go down this path?

I could take a patch fixing them all at once (this time). It's you
who'll have to deal with the changed contexts when back porting device
ids, Greg. ;)

Johan
Greg KH
2014-10-22 14:18:57 UTC
Permalink
Raw Message
Post by Johan Hovold
Post by Greg KH
Post by Philip Munksgaard
Fix a style issue
---
drivers/usb/serial/option.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index d1a3f60..d88998d 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -1616,7 +1616,7 @@ static const struct usb_device_id option_ids[] = {
{ USB_DEVICE(TLAYTECH_VENDOR_ID, TLAYTECH_PRODUCT_TEU800) },
{ USB_DEVICE(LONGCHEER_VENDOR_ID, FOUR_G_SYSTEMS_PRODUCT_W14),
.driver_info = (kernel_ulong_t)&four_g_w14_blacklist
- },
+ },
Why not fix the same 'space' issue on the line before this at the same
time?
And what about the remaining white-space issues in this file? Do we
really want to go down this path?
No, we don't, if you want to have patches be able to apply properly to
older kernels, as you point out.

Just don't add new whitespace issues please, that's all.

thanks,

greg k-h
Philip Munksgaard
2014-10-22 14:40:24 UTC
Permalink
Raw Message
Post by Greg KH
Post by Johan Hovold
Post by Greg KH
Post by Philip Munksgaard
Fix a style issue
---
drivers/usb/serial/option.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index d1a3f60..d88998d 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -1616,7 +1616,7 @@ static const struct usb_device_id option_ids[] = {
{ USB_DEVICE(TLAYTECH_VENDOR_ID, TLAYTECH_PRODUCT_TEU800) },
{ USB_DEVICE(LONGCHEER_VENDOR_ID, FOUR_G_SYSTEMS_PRODUCT_W14),
.driver_info = (kernel_ulong_t)&four_g_w14_blacklist
- },
+ },
Why not fix the same 'space' issue on the line before this at the same
time?
And what about the remaining white-space issues in this file? Do we
really want to go down this path?
No, we don't, if you want to have patches be able to apply properly to
older kernels, as you point out.
Just don't add new whitespace issues please, that's all.
I'm a bit confused. I've already submitted a new patch that merges the
two lines and fixes the whitespace issues on both (if you can't find
it, let me know and I'll resend it), is there anything else I'm
supposed to do?
Johan Hovold
2014-10-22 14:40:31 UTC
Permalink
Raw Message
Post by Philip Munksgaard
Post by Greg KH
Post by Johan Hovold
Post by Greg KH
Post by Philip Munksgaard
Fix a style issue
---
drivers/usb/serial/option.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index d1a3f60..d88998d 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -1616,7 +1616,7 @@ static const struct usb_device_id option_ids[] = {
{ USB_DEVICE(TLAYTECH_VENDOR_ID, TLAYTECH_PRODUCT_TEU800) },
{ USB_DEVICE(LONGCHEER_VENDOR_ID, FOUR_G_SYSTEMS_PRODUCT_W14),
.driver_info = (kernel_ulong_t)&four_g_w14_blacklist
- },
+ },
Why not fix the same 'space' issue on the line before this at the same
time?
And what about the remaining white-space issues in this file? Do we
really want to go down this path?
No, we don't, if you want to have patches be able to apply properly to
older kernels, as you point out.
Just don't add new whitespace issues please, that's all.
I'm a bit confused. I've already submitted a new patch that merges the
two lines and fixes the whitespace issues on both (if you can't find
it, let me know and I'll resend it), is there anything else I'm
supposed to do?
No, we're just not going to apply such fix-white-space patches, sorry.

Johan
Paul Zimmerman
2014-10-22 21:14:14 UTC
Permalink
Raw Message
Sent: Wednesday, October 22, 2014 7:19 AM
Post by Johan Hovold
Post by Greg KH
Post by Philip Munksgaard
Fix a style issue
---
drivers/usb/serial/option.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index d1a3f60..d88998d 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -1616,7 +1616,7 @@ static const struct usb_device_id option_ids[] = {
{ USB_DEVICE(TLAYTECH_VENDOR_ID, TLAYTECH_PRODUCT_TEU800) },
{ USB_DEVICE(LONGCHEER_VENDOR_ID, FOUR_G_SYSTEMS_PRODUCT_W14),
.driver_info = (kernel_ulong_t)&four_g_w14_blacklist
- },
+ },
Why not fix the same 'space' issue on the line before this at the same
time?
And what about the remaining white-space issues in this file? Do we
really want to go down this path?
No, we don't, if you want to have patches be able to apply properly to
older kernels, as you point out.
git-apply --ignore-whitespace ?
--
Paul
Greg KH
2014-10-22 21:40:26 UTC
Permalink
Raw Message
Post by Paul Zimmerman
Sent: Wednesday, October 22, 2014 7:19 AM
Post by Johan Hovold
Post by Greg KH
Post by Philip Munksgaard
Fix a style issue
---
drivers/usb/serial/option.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index d1a3f60..d88998d 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -1616,7 +1616,7 @@ static const struct usb_device_id option_ids[] = {
{ USB_DEVICE(TLAYTECH_VENDOR_ID, TLAYTECH_PRODUCT_TEU800) },
{ USB_DEVICE(LONGCHEER_VENDOR_ID, FOUR_G_SYSTEMS_PRODUCT_W14),
.driver_info = (kernel_ulong_t)&four_g_w14_blacklist
- },
+ },
Why not fix the same 'space' issue on the line before this at the same
time?
And what about the remaining white-space issues in this file? Do we
really want to go down this path?
No, we don't, if you want to have patches be able to apply properly to
older kernels, as you point out.
git-apply --ignore-whitespace ?
Doesn't work with my code-flow for handling stable patches, sorry.

greg k-h

Philip Munksgaard
2014-10-11 15:24:01 UTC
Permalink
Raw Message
Fix a style issue.

Signed-off-by: Philip Munksgaard <***@gmail.com>
---
drivers/usb/serial/option.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index d1a3f60..64ddc00 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -1615,8 +1615,7 @@ static const struct usb_device_id option_ids[] = {
{ USB_DEVICE(AIRPLUS_VENDOR_ID, AIRPLUS_PRODUCT_MCD650) },
{ USB_DEVICE(TLAYTECH_VENDOR_ID, TLAYTECH_PRODUCT_TEU800) },
{ USB_DEVICE(LONGCHEER_VENDOR_ID, FOUR_G_SYSTEMS_PRODUCT_W14),
- .driver_info = (kernel_ulong_t)&four_g_w14_blacklist
- },
+ .driver_info = (kernel_ulong_t)&four_g_w14_blacklist },
{ USB_DEVICE_INTERFACE_CLASS(LONGCHEER_VENDOR_ID, SPEEDUP_PRODUCT_SU9800, 0xff) },
{ USB_DEVICE(LONGCHEER_VENDOR_ID, ZOOM_PRODUCT_4597) },
{ USB_DEVICE(LONGCHEER_VENDOR_ID, IBALL_3_5G_CONNECT) },
--
2.1.2
Loading...