usb-audio: Fix invalid volume resolution for Logitech HD Webcam C525

Discussion:

Maksim A. Boyko

2013-08-09 08:20:06 UTC

Add the volume control quirk for avoiding the kernel warning
for the Logitech HD Webcam C525
as in the similar commit 36691e1be6ec551eef4a5225f126a281f8c051c2
for the Logitech HD Webcam C310.

Reported-by: Maksim Boyko <***@gmail.com>
Tested-by: Maksim Boyko <***@gmail.com>
Cc: <***@vger.kernel.org> # 3.10.5+
Signed-off-by: Maksim Boyko <***@gmail.com>
--
sound/usb/mixer.c | 1 +
1 file changed, 1 insertion(+)

--- linux-3.10.5-orig/sound/usb/mixer.c 2013-08-04 12:51:49.000000000 +0400
+++ linux-3.10.5/sound/usb/mixer.c 2013-08-06 21:12:42.274197287 +0400
@@ -888,6 +888,7 @@ static void volume_control_quirks(struct
case USB_ID(0x046d, 0x081b): /* HD Webcam c310 */
case USB_ID(0x046d, 0x081d): /* HD Webcam c510 */
case USB_ID(0x046d, 0x0825): /* HD Webcam c270 */
+ case USB_ID(0x046d, 0x0826): /* HD Webcam c525 */
case USB_ID(0x046d, 0x0991):
/* Most audio usb devices lie about volume resolution.
* Most Logitech webcams have res = 384.

--
Best regards, Maksim A. Boyko

Maxim Boyko

2013-08-09 08:37:49 UTC

Permalink

Add the volume control quirk for avoiding the kernel warning
for the Logitech HD Webcam C525
as in the similar commit 36691e1be6ec551eef4a5225f126a281f8c051c2
for the Logitech HD Webcam C310.

Reported-by: Maksim Boyko <maksim.a.boyko-***@public.gmane.org>
Tested-by: Maksim Boyko <maksim.a.boyko-***@public.gmane.org>
Cc: <stable-***@public.gmane.org> # 3.10.5+
Signed-off-by: Maksim Boyko <maksim.a.boyko-***@public.gmane.org>
--
sound/usb/mixer.c | 1 +
1 file changed, 1 insertion(+)

--- linux-3.10.5-orig/sound/usb/mixer.c 2013-08-04 12:51:49.000000000
+0400
+++ linux-3.10.5/sound/usb/mixer.c 2013-08-06 21:12:42.274197287
+0400
@@ -888,6 +888,7 @@ static void volume_control_quirks(struct
case USB_ID(0x046d, 0x081b): /* HD Webcam c310 */
case USB_ID(0x046d, 0x081d): /* HD Webcam c510 */
case USB_ID(0x046d, 0x0825): /* HD Webcam c270 */
+ case USB_ID(0x046d, 0x0826): /* HD Webcam c525 */
case USB_ID(0x046d, 0x0991):
/* Most audio usb devices lie about volume resolution.
* Most Logitech webcams have res = 384.

--
WBR, Maksim

P.S. Please, use this patch due to it should have correct tab symbols.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-***@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

Maksim A. Boyko

2013-08-10 08:20:02 UTC

Permalink

Add the volume control quirk for avoiding the kernel warning
for the Logitech HD Webcam C525
as in the similar commit 36691e1be6ec551eef4a5225f126a281f8c051c2
for the Logitech HD Webcam C310.

Reported-by: Maksim Boyko <***@gmail.com>
Tested-by: Maksim Boyko <***@gmail.com>
Cc: <***@vger.kernel.org> # 3.10.5+
Signed-off-by: Maksim Boyko <***@gmail.com>
--
sound/usb/mixer.c | 1 +
1 file changed, 1 insertion(+)

--- linux-3.10.5-orig/sound/usb/mixer.c 2013-08-04 12:51:49.000000000
+0400
+++ linux-3.10.5/sound/usb/mixer.c 2013-08-06 21:12:42.274197287
+0400
@@ -888,6 +888,7 @@ static void volume_control_quirks(struct
case USB_ID(0x046d, 0x081b): /* HD Webcam c310 */
case USB_ID(0x046d, 0x081d): /* HD Webcam c510 */
case USB_ID(0x046d, 0x0825): /* HD Webcam c270 */
+ case USB_ID(0x046d, 0x0826): /* HD Webcam c525 */
case USB_ID(0x046d, 0x0991):
/* Most audio usb devices lie about volume resolution.
* Most Logitech webcams have res = 384.

--
WBR, Maksim

P.S. Please, use this patch due to it should have correct tab symbols.

Sergei Shtylyov

2013-08-10 18:39:52 UTC

Permalink

Hello.

Post by Maksim A. Boyko
Add the volume control quirk for avoiding the kernel warning
for the Logitech HD Webcam C525
as in the similar commit 36691e1be6ec551eef4a5225f126a281f8c051c2

Please also specify that commit's summary line in parens.

Post by Maksim A. Boyko
for the Logitech HD Webcam C310.
--
sound/usb/mixer.c | 1 +
1 file changed, 1 insertion(+)
--- linux-3.10.5-orig/sound/usb/mixer.c 2013-08-04 12:51:49.000000000
+0400
+++ linux-3.10.5/sound/usb/mixer.c 2013-08-06 21:12:42.274197287
+0400
@@ -888,6 +888,7 @@ static void volume_control_quirks(struct
case USB_ID(0x046d, 0x081b): /* HD Webcam c310 */
case USB_ID(0x046d, 0x081d): /* HD Webcam c510 */
case USB_ID(0x046d, 0x0825): /* HD Webcam c270 */
+ case USB_ID(0x046d, 0x0826): /* HD Webcam c525 */
/* Most audio usb devices lie about volume resolution.
* Most Logitech webcams have res = 384.
--
WBR, Maksim
P.S. Please, use this patch due to it should have correct tab symbols.

Unfortunately, it seems to have a space added before each line starting
with space.

WBR, Sergei

Takashi Iwai

2013-08-12 12:55:45 UTC

Permalink

At Sat, 10 Aug 2013 12:20:02 +0400,

Post by Maksim A. Boyko
Add the volume control quirk for avoiding the kernel warning
for the Logitech HD Webcam C525
as in the similar commit 36691e1be6ec551eef4a5225f126a281f8c051c2
for the Logitech HD Webcam C310.

Thanks, applied.

Takashi

Post by Maksim A. Boyko
--
sound/usb/mixer.c | 1 +
1 file changed, 1 insertion(+)
--- linux-3.10.5-orig/sound/usb/mixer.c 2013-08-04 12:51:49.000000000
+0400
+++ linux-3.10.5/sound/usb/mixer.c 2013-08-06 21:12:42.274197287
+0400
@@ -888,6 +888,7 @@ static void volume_control_quirks(struct
case USB_ID(0x046d, 0x081b): /* HD Webcam c310 */
case USB_ID(0x046d, 0x081d): /* HD Webcam c510 */
case USB_ID(0x046d, 0x0825): /* HD Webcam c270 */
+ case USB_ID(0x046d, 0x0826): /* HD Webcam c525 */
/* Most audio usb devices lie about volume resolution.
* Most Logitech webcams have res = 384.
--
WBR, Maksim
P.S. Please, use this patch due to it should have correct tab symbols.
_______________________________________________
Alsa-devel mailing list
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-***@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

Maxim Boyko

2013-08-09 08:28:35 UTC

Permalink

Add the volume control quirk for avoiding the kernel warning
for the Logitech HD Webcam C525
as in the similar commit 36691e1be6ec551eef4a5225f126a281f8c051c2
for the Logitech HD Webcam C310.

Reported-by: Maksim Boyko <***@gmail.com>
Tested-by: Maksim Boyko <***@gmail.com>
Cc: <***@vger.kernel.org> # 3.10.5+
Signed-off-by: Maksim Boyko <***@gmail.com>
--
sound/usb/mixer.c | 1 +
1 file changed, 1 insertion(+)

--- linux-3.10.5-orig/sound/usb/mixer.c 2013-08-04 12:51:49.000000000
+0400
+++ linux-3.10.5/sound/usb/mixer.c 2013-08-06 21:12:42.274197287
+0400
@@ -888,6 +888,7 @@ static void volume_control_quirks(struct
case USB_ID(0x046d, 0x081b): /* HD Webcam c310 */
case USB_ID(0x046d, 0x081d): /* HD Webcam c510 */
case USB_ID(0x046d, 0x0825): /* HD Webcam c270 */
+ case USB_ID(0x046d, 0x0826): /* HD Webcam c525 */
case USB_ID(0x046d, 0x0991):
/* Most audio usb devices lie about volume resolution.
* Most Logitech webcams have res = 384.

--
WBR, Maksim Boyko

Maksim A. Boyko

2013-08-11 08:39:23 UTC

Permalink

Add the volume control quirk for avoiding the kernel warning for the Logitech HD
Webcam C525 as in the similar commit 36691e1be6ec551eef4a5225f126a281f8c051c2
(ALSA: usb-audio: Fix invalid volume resolution for Logitech HD Webcam c310) for
the Logitech HD Webcam C310.

Reported-by: Maksim Boyko <***@gmail.com>
Tested-by: Maksim Boyko <***@gmail.com>
Cc: <***@vger.kernel.org> # 3.10.5+
Signed-off-by: Maksim Boyko <***@gmail.com>
--
sound/usb/mixer.c | 1 +
1 file changed, 1 insertion(+)

--- linux-3.10.5-orig/sound/usb/mixer.c 2013-08-04 12:51:49.000000000
+0400
+++ linux-3.10.5/sound/usb/mixer.c 2013-08-06 21:12:42.274197287
+0400
@@ -888,6 +888,7 @@ static void volume_control_quirks(struct
case USB_ID(0x046d, 0x081b): /* HD Webcam c310 */
case USB_ID(0x046d, 0x081d): /* HD Webcam c510 */
case USB_ID(0x046d, 0x0825): /* HD Webcam c270 */
+ case USB_ID(0x046d, 0x0826): /* HD Webcam c525 */
case USB_ID(0x046d, 0x0991):
/* Most audio usb devices lie about volume resolution.
* Most Logitech webcams have res = 384.

--
WBR, Maksim Boyko

Sergei Shtylyov

2013-08-11 17:23:32 UTC

Permalink

Hello.

Post by Maksim A. Boyko
Add the volume control quirk for avoiding the kernel warning for the Logitech HD
Webcam C525 as in the similar commit 36691e1be6ec551eef4a5225f126a281f8c051c2
(ALSA: usb-audio: Fix invalid volume resolution for Logitech HD Webcam c310) for
the Logitech HD Webcam C310.

Strange, now all the surrounding lines are indented with spaces, only the
line you're adding looks normal.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-***@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html